Skip to content

Comments

Bug 1805710: Add non-virtual-ip and nodeip-finder scripts#48

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-46-to-release-4.4
Feb 27, 2020
Merged

Bug 1805710: Add non-virtual-ip and nodeip-finder scripts#48
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-46-to-release-4.4

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 21, 2020

This is an automated cherry-pick of #46

/assign vrutkovs

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2020

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.4] Add non-virtual-ip script

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 21, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 21, 2020
@vrutkovs
Copy link

vrutkovs commented Feb 21, 2020

/retitle Bug 1805710: Add non-virtual-ip and nodeip-finder scripts

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Add non-virtual-ip script Bug 1805710: Add non-virtual-ip and nodeip-finder scripts Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1805710, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead
  • expected Bugzilla bug 1805710 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1805710: Add non-virtual-ip and nodeip-finder scripts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 21, 2020
@vrutkovs
Copy link

vrutkovs commented Feb 21, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2020

@vrutkovs: This pull request references Bugzilla bug 1805710, which is invalid:

  • expected dependent Bugzilla bug 1805715 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link

vrutkovs commented Feb 21, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2020

@vrutkovs: This pull request references Bugzilla bug 1805710, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 21, 2020
@vrutkovs vrutkovs mentioned this pull request Feb 21, 2020
Merged
@celebdor
Copy link
Contributor

celebdor commented Feb 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit e5def1e into openshift:release-4.4 Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1805710 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1805710: Add non-virtual-ip and nodeip-finder scripts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@cybertron cybertron Awaiting requested review from cybertron

Assignees

@vrutkovs vrutkovs

@celebdor celebdor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @vrutkovs @celebdor @openshift-merge-robot